Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #8446] Add more test coverage for MQClientInstance #8447

Merged
merged 3 commits into from
Jul 26, 2024
Merged

[ISSUE #8446] Add more test coverage for MQClientInstance #8447

merged 3 commits into from
Jul 26, 2024

Conversation

yx9o
Copy link
Contributor

@yx9o yx9o commented Jul 25, 2024

Fixes #8446 .

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.87%. Comparing base (59c8609) to head (dbe07e6).

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #8447      +/-   ##
=============================================
+ Coverage      45.78%   45.87%   +0.09%     
- Complexity     11078    11098      +20     
=============================================
  Files           1274     1274              
  Lines          89001    89001              
  Branches       11441    11441              
=============================================
+ Hits           40746    40829      +83     
+ Misses         43191    43073     -118     
- Partials        5064     5099      +35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShannonDing ShannonDing added the soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on label Jul 26, 2024
@ShannonDing
Copy link
Member

link #8262

@RongtongJin RongtongJin merged commit 304987d into apache:develop Jul 26, 2024
10 checks passed
@yx9o yx9o deleted the dev-8446 branch July 26, 2024 04:03
Qoozm pushed a commit to Qoozm/rocketmq that referenced this pull request Jul 26, 2024
@yx9o @Qoozm
[ISSUE apache#8446] Add more test coverage for MQClientInstance (apac…
9b43dc3 
…he#8447)

* [ISSUE apache#8446] Add more test coverage for MQClientInstance

* Update

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShannonDing ShannonDing ShannonDing approved these changes

@RongtongJin RongtongJin RongtongJin approved these changes

Assignees
No one assigned
Labels
soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add more test coverage for MQClientInstance
4 participants
@yx9o @codecov-commenter @ShannonDing @RongtongJin