[ISSUE #8486]Add more test coverage for BrokerMetricsManager #8487
Conversation
- check the topic is retry or dlq topic - check the group is system group or not - check the topic and the group belongs to system or not
… by request header.
|
for soc in #8262 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8487 +/- ##
=============================================
+ Coverage 46.01% 46.46% +0.45%
- Complexity 11144 11200 +56
=============================================
Files 1274 1274
Lines 89008 89022 +14
Branches 11444 11448 +4
=============================================
+ Hits 40958 41368 +410
+ Misses 42925 42526 -399
- Partials 5125 5128 +3 ☔ View full report in Codecov by Sentry. |
|
Thank you~ |
ShannonDing
added
the
soc
Bazel-complie check isn't required for pr merging, but u can try to fix it in a new pr. |
ShannonDing
changed the title
|
@ziiyee A reminder from the Tianchi platform: it‘s better to submit your results to the official website asap. |
Thanks a lot, it's a good event. |
Which Issue(s) This PR Fixes
Fixes #8486
Brief Description
Add more test coverage.
Before:
After:
How Did You Test This Change?
All tests passed.
PS: TONGYI Lingma provided code generation and programming support.
