Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added github actions for basic build/test setup. #113

Merged
merged 3 commits into from
Dec 27, 2021

Conversation

mbien
Copy link
Member

@mbien mbien commented Dec 25, 2021

  • builds/tests on JDK 11 and 17
  • uploads junit report
  • disabled a failing test for now

 - runs on JDK 11 and 17
 - reports test results
@mbien mbien requested a review from snoopdave December 25, 2021 09:06
@mbien
Copy link
Member Author

mbien commented Dec 25, 2021

i think the junit report will start working once the yaml is in master.
should look like this: https://github.com/mbien/roller/runs/4631232068?check_suite_focus=true
and if something fails:
https://github.com/mbien/roller/runs/4631155838?check_suite_focus=true

@mbien
Copy link
Member Author

mbien commented Dec 25, 2021

added step for selenium tests (didn't know that geckodriver could run headless).

Copy link
Contributor

@snoopdave snoopdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very cool. I have not tried it out yet, but I see no reason not to merge.

@mbien
Copy link
Member Author

mbien commented Dec 27, 2021

awesome. I merge it, lets see if everything builds.

@mbien mbien merged commit 683ca63 into apache:master Dec 27, 2021
@mbien
Copy link
Member Author

mbien commented Dec 27, 2021

it builds and tests but it didn't upload the test report (it should appear on the list on the left i think)
https://github.com/apache/roller/actions/runs/1627718913

Don't know why because I tested it on my wip branch and it worked fine. (but its not so important tbh, the full log is recorded anyway in case something fails)

@mbien
Copy link
Member Author

mbien commented Dec 27, 2021

oh haha. It published it in he CodeQL action
https://github.com/apache/roller/actions/runs/1627718912

@mbien
Copy link
Member Author

mbien commented Dec 27, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants