From 2f4ca01fe043257cb24f320b3b812c27c7fb4d67 Mon Sep 17 00:00:00 2001
From: dailai <837833280@qq.com>
Date: Tue, 29 Oct 2024 17:04:20 +0800
Subject: [PATCH] [Improve][Zeta] Make the default value of
 classloader-cache-mode is true (#7938)

---
 config/seatunnel.yaml                                         | 1 +
 docs/en/seatunnel-engine/hybrid-cluster-deployment.md         | 4 ++--
 docs/en/seatunnel-engine/separated-cluster-deployment.md      | 4 ++--
 .../engine/common/config/server/ServerConfigOptions.java      | 2 +-
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/config/seatunnel.yaml b/config/seatunnel.yaml
index 4e7ef0c7001..f773204eba2 100644
--- a/config/seatunnel.yaml
+++ b/config/seatunnel.yaml
@@ -17,6 +17,7 @@
 
 seatunnel:
   engine:
+    classloader-cache-mode: true
     history-job-expire-minutes: 1440
     backup-count: 1
     queue-type: blockingqueue
diff --git a/docs/en/seatunnel-engine/hybrid-cluster-deployment.md b/docs/en/seatunnel-engine/hybrid-cluster-deployment.md
index 85a169d221e..0f4ecf86b7c 100644
--- a/docs/en/seatunnel-engine/hybrid-cluster-deployment.md
+++ b/docs/en/seatunnel-engine/hybrid-cluster-deployment.md
@@ -127,7 +127,7 @@ seatunnel:
 This configuration primarily addresses the issue of resource leakage caused by constantly creating and attempting to destroy the class loader.
 If you encounter exceptions related to metaspace overflow, you can try enabling this configuration.
 To reduce the frequency of class loader creation, after enabling this configuration, SeaTunnel will not attempt to release the corresponding class loader when a job is completed, allowing it to be used by subsequent jobs. This is more effective when the number of Source/Sink connectors used in the running job is not excessive.
-The default value is false.
+The default value is true.
 Example
 
 ```yaml
@@ -337,4 +337,4 @@ Now that the cluster is deployed, you can complete the submission and management
 
 ### 8.2 Submit Jobs With The REST API
 
-The SeaTunnel Engine provides a REST API for submitting and managing jobs. For more information, please refer to [REST API V2](rest-api-v2.md)
\ No newline at end of file
+The SeaTunnel Engine provides a REST API for submitting and managing jobs. For more information, please refer to [REST API V2](rest-api-v2.md)
diff --git a/docs/en/seatunnel-engine/separated-cluster-deployment.md b/docs/en/seatunnel-engine/separated-cluster-deployment.md
index 68f3d011679..6b745974970 100644
--- a/docs/en/seatunnel-engine/separated-cluster-deployment.md
+++ b/docs/en/seatunnel-engine/separated-cluster-deployment.md
@@ -173,7 +173,7 @@ seatunnel:
 This configuration mainly solves the problem of resource leakage caused by continuously creating and attempting to destroy class loaders.
 If you encounter an exception related to metaspace space overflow, you can try to enable this configuration.
 In order to reduce the frequency of creating class loaders, after enabling this configuration, SeaTunnel will not try to release the corresponding class loader when the job is completed, so that it can be used by subsequent jobs, that is to say, when not too many types of Source/Sink connector are used in the running job, it is more effective.
-The default value is false.
+The default value is true.
 Example
 
 ```yaml
@@ -448,4 +448,4 @@ Now that the cluster has been deployed, you can complete the job submission and
 
 ### 8.2 Submit Jobs With The REST API
 
-The SeaTunnel Engine provides a REST API for submitting and managing jobs. For more information, please refer to [REST API V2](rest-api-v2.md)
\ No newline at end of file
+The SeaTunnel Engine provides a REST API for submitting and managing jobs. For more information, please refer to [REST API V2](rest-api-v2.md)
diff --git a/seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/config/server/ServerConfigOptions.java b/seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/config/server/ServerConfigOptions.java
index 37ec8674a1c..d9e9662a990 100644
--- a/seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/config/server/ServerConfigOptions.java
+++ b/seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/config/server/ServerConfigOptions.java
@@ -207,7 +207,7 @@ public class ServerConfigOptions {
     public static final Option<Boolean> CLASSLOADER_CACHE_MODE =
             Options.key("classloader-cache-mode")
                     .booleanType()
-                    .defaultValue(false)
+                    .defaultValue(true)
                     .withDescription(
                             "Whether to use classloader cache mode. With cache mode, all jobs share the same classloader if the jars are the same");