Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eyes] Absolute path resolution bug in git ignore and check escape #7543

Closed
wu-sheng opened this issue Aug 23, 2021 · 1 comment · Fixed by apache/skywalking-eyes#67
Closed
Assignees
Labels
bug Something isn't working and you are sure it's a bug! feature New feature license eye

Comments

@wu-sheng
Copy link
Member

  1. The paths-ignore are the path list that will be ignored by license-eye. By default, .git and the content in .gitignore will be inflated into the paths-ignore list.

I found this at doc, https://github.com/apache/skywalking-eyes#configurations.

So, according to doc, this is a bug.

But I would be very surprised about this folder includes actually managed files. @spacewander I think this feature was designed to skip local(never submitted files).


@kezhenxu94 @fgksgf I would treat APISIX's use case as a very specific leak case for header check. It is better to provide a local-mode(or any better name) to accept git ignore file.

Once you have a resolution, you could create a bug/feature issue with good explanations about how we should fix this. Or we could continue the discussion here.

Originally posted by @wu-sheng in #7542 (reply in thread)

@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! feature New feature labels Aug 23, 2021
@wu-sheng wu-sheng added this to the license-eye 0.2.0 milestone Aug 23, 2021
@wu-sheng
Copy link
Member Author

wu-sheng commented Aug 23, 2021

This discussion based issue includes a bug and a feature request.

@kezhenxu94 @fgksgf Please make the final decision.(Decision doesn't mean you have to fix by yourself)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working and you are sure it's a bug! feature New feature license eye
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants