From 3cafda5294c382f06d816bb2479db2e16d9bd6dc Mon Sep 17 00:00:00 2001 From: uncleGen Date: Mon, 30 Nov 2015 11:04:45 +0800 Subject: [PATCH] bug fix --- .../scala/org/apache/spark/util/random/SamplingUtils.scala | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala b/core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala index 0a8c59bbaae96..f98932a470165 100644 --- a/core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala +++ b/core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala @@ -56,11 +56,7 @@ private[spark] object SamplingUtils { val rand = new XORShiftRandom(seed) while (input.hasNext) { val item = input.next() - val replacementIndex = if (l < Int.MaxValue) { - rand.nextInt(l.toInt) - } else { - rand.nextLong() - } + val replacementIndex = (rand.nextDouble() * l).toLong if (replacementIndex < k) { reservoir(replacementIndex.toInt) = item }