From bb2ed41112901ab64d6b74b39389e60d76c173f3 Mon Sep 17 00:00:00 2001 From: uncleGen Date: Sat, 28 Nov 2015 17:47:43 +0800 Subject: [PATCH] modify some pointless and verbose code --- .../org/apache/spark/util/random/SamplingUtils.scala | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala b/core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala index f17ac7fb6a8e3..0a8c59bbaae96 100644 --- a/core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala +++ b/core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala @@ -56,12 +56,13 @@ private[spark] object SamplingUtils { val rand = new XORShiftRandom(seed) while (input.hasNext) { val item = input.next() - val replacementIndex = l < Int.MaxValue match { - case true => rand.nextInt(l.toInt) - case false => rand.nextInt() + val replacementIndex = if (l < Int.MaxValue) { + rand.nextInt(l.toInt) + } else { + rand.nextLong() } if (replacementIndex < k) { - reservoir(replacementIndex) = item + reservoir(replacementIndex.toInt) = item } l += 1 }