Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Targeted User for internal StreamPipes notification sink #2314

Open
bossenti opened this issue Dec 12, 2023 · 2 comments
Open

Targeted User for internal StreamPipes notification sink #2314

bossenti opened this issue Dec 12, 2023 · 2 comments
Milestone
post-1.0

Comments

@bossenti
Copy link
Contributor

Body

The InternalStreamPipesNotificationSink contained that following inline TODO which is replaced by this issue.

// TODO add targeted user to notification object

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.
@bossenti bossenti added this to the post-1.0 milestone Dec 12, 2023
@bossenti bossenti mentioned this issue Dec 12, 2023
Merged
@IsaakKrut
Copy link
Contributor

Hi @bossenti , I see that targetedAt is already set to correspondingUser on the notification object. Could you add some background information about this issue and what changes are expected to be made?

@bossenti
Copy link
Contributor Author

TBH, I haven't checked if this already implemented. I just wanted to replace the TODO comment with this issue. If the the TODO is already implemented, we can close this issue 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-1.0
Development

No branches or pull requests
2 participants
@IsaakKrut @bossenti