User edit dialog expects username

[bossenti]

Apache StreamPipes version

dev (current development state)

Affected StreamPipes components

UI

What happened?

When editing a user in the user management, the dialog expects the user name to be provided.

This is an issue since the username is never present when the user was created through self-registration.

How to reproduce?

No response

Expected behavior

No response

Additional technical information

No response

Are you willing to submit a PR?

No, I don't want to submit a PR.

[muyangye]

Hey @bossenti! This issue also occurs when some other admins want to edit the initial admin [email protected]. I believe the expected behavior is that the username field is not required right? If so it's just a one-line change. I have found the line but since this change is so simple, maybe we should label it as a good-first-issue so that first time contributors can have a try? If nobody claimes it for say 2 months, I'll push the fix.

[bossenti]

Good idea @muyangye, let's do it like that
In addition, we can think of if we want to keep the property Full Name both in the UI and the data model. AFAIK, it is not used currently

[muyangye]

In my opinion, we should probably keep it despite it's not currently used in code because users might want to know that attribute. For example, an assembly line may have multiple industrial/manufactural engineers who use StreamPipes and they/their admin might be interested in knowing who is who. What do you think?

[bossenti]

Yes, I agree. In mid-/longterm we might want to use it, especially if integrating SSO somewhen