From 210a2b90532003780f713a1463a031f5a5a31747 Mon Sep 17 00:00:00 2001
From: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Date: Fri, 9 Sep 2022 20:28:46 -0500
Subject: [PATCH] test: Fix act errors in DndFilterSelect test (#21429)
---
.../DndFilterSelect.test.tsx | 28 ++++++++++++-------
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.test.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.test.tsx
index 7371d7bb488a1..92a1597dcdc56 100644
--- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.test.tsx
+++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.test.tsx
@@ -48,12 +48,14 @@ const baseFormData = {
datasource: 'table__1',
};
-test('renders with default props', () => {
+test('renders with default props', async () => {
render(, { useDnd: true });
- expect(screen.getByText('Drop columns or metrics here')).toBeInTheDocument();
+ expect(
+ await screen.findByText('Drop columns or metrics here'),
+ ).toBeInTheDocument();
});
-test('renders with value', () => {
+test('renders with value', async () => {
const value = new AdhocFilter({
sqlExpression: 'COUNT(*)',
expressionType: EXPRESSION_TYPES.SQL,
@@ -61,10 +63,10 @@ test('renders with value', () => {
render(, {
useDnd: true,
});
- expect(screen.getByText('COUNT(*)')).toBeInTheDocument();
+ expect(await screen.findByText('COUNT(*)')).toBeInTheDocument();
});
-test('renders options with saved metric', () => {
+test('renders options with saved metric', async () => {
render(
{
useDnd: true,
},
);
- expect(screen.getByText('Drop columns or metrics here')).toBeInTheDocument();
+ expect(
+ await screen.findByText('Drop columns or metrics here'),
+ ).toBeInTheDocument();
});
-test('renders options with column', () => {
+test('renders options with column', async () => {
render(
{
useDnd: true,
},
);
- expect(screen.getByText('Drop columns or metrics here')).toBeInTheDocument();
+ expect(
+ await screen.findByText('Drop columns or metrics here'),
+ ).toBeInTheDocument();
});
-test('renders options with adhoc metric', () => {
+test('renders options with adhoc metric', async () => {
const adhocMetric = new AdhocMetric({
expression: 'AVG(birth_names.num)',
metric_name: 'avg__num',
@@ -119,5 +125,7 @@ test('renders options with adhoc metric', () => {
useDnd: true,
},
);
- expect(screen.getByText('Drop columns or metrics here')).toBeInTheDocument();
+ expect(
+ await screen.findByText('Drop columns or metrics here'),
+ ).toBeInTheDocument();
});