diff --git a/superset-frontend/src/components/Chart/DrillBy/DrillByMenuItems.tsx b/superset-frontend/src/components/Chart/DrillBy/DrillByMenuItems.tsx index d1a27d5ea9db6..d45baa0133c3e 100644 --- a/superset-frontend/src/components/Chart/DrillBy/DrillByMenuItems.tsx +++ b/superset-frontend/src/components/Chart/DrillBy/DrillByMenuItems.tsx @@ -244,15 +244,17 @@ export const DrillByMenuItems = ({ )} - + {showModal && ( + + )} ); }; diff --git a/superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx b/superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx index 3815a996799a5..3f175f09608eb 100644 --- a/superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx +++ b/superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx @@ -46,16 +46,11 @@ import { getChartDataRequest } from '../chartAction'; const DATA_SIZE = 14; interface ModalFooterProps { - formData: BaseFormData; closeModal?: () => void; - showEditChart: boolean; + formData: BaseFormData; } -const ModalFooter = ({ - formData, - closeModal, - showEditChart, -}: ModalFooterProps) => { +const ModalFooter = ({ formData, closeModal }: ModalFooterProps) => { const [url, setUrl] = useState(''); const dashboardPageId = useContext(DashboardPageIdContext); const [datasource_id, datasource_type] = formData.datasource.split('__'); @@ -72,20 +67,19 @@ const ModalFooter = ({ }, [dashboardPageId, datasource_id, datasource_type, formData]); return ( <> - {showEditChart && ( - - )} + +