Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] New pie chart labels and control overlap with controls & actual viz #11243

Closed
2 tasks done
bkyryliuk opened this issue Oct 12, 2020 · 7 comments
Closed
2 tasks done
Assignees
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@bkyryliuk
Copy link
Member

New pie chart labels look messy in the dashboard view and there are some issues in the explore view as well.
Screenshots provide additional context

Expected results

image

Actual results

image

image

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@bkyryliuk bkyryliuk added the !deprecated-label:bug Deprecated label - Use #bug instead label Oct 12, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@bkyryliuk
Copy link
Member Author

bkyryliuk commented Oct 12, 2020

cc @junlincc @eugeniamz @villebro
probably introduced here: #10966

Disabling put labels outside makes things even worse, a potential fix could be a certain threshold for the values to show, e.g. only values > 5 %

@bkyryliuk
Copy link
Member Author

Another example, current:
image

Previous:
image

@junlincc
Copy link
Member

@bkyryliuk hey Bogdan, thanks for reporting. we are aware of this issue and will work on it!

@villebro
Copy link
Member

@bkyryliuk this PR should fix threshold + blurriness problems introduced by the new chart: apache-superset/superset-ui#806

@bkyryliuk
Copy link
Member Author

@bkyryliuk this PR should fix threshold + blurriness problems introduced by the new chart: apache-superset/superset-ui#806

Wow, thank you for the prompt fix!

@junlincc
Copy link
Member

issue resolved! thank you so much Ville!! closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

No branches or pull requests

3 participants