Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] chart loading spinner didn't show #12264

Closed
3 tasks done
graceguo-supercat opened this issue Jan 5, 2021 · 1 comment · Fixed by #12288
Closed
3 tasks done

[dashboard] chart loading spinner didn't show #12264

graceguo-supercat opened this issue Jan 5, 2021 · 1 comment · Fixed by #12288
Assignees
Labels
#bug:regression Bugs that are identified as regessions P1 Priority item - Major

Comments

@graceguo-supercat
Copy link

graceguo-supercat commented Jan 5, 2021

A clear and concise description of what the bug is.

Screenshots

83vMV7zabc

How to reproduce the bug

  1. Go to a dashboard with a lot of charts and less cached data.
  2. You should see spinner when chart is loading, but it is not showing right now. When chart is loaded, the chart area is empty blank.
  3. But you can see spinner when you force refresh a chart.

Environment

latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

It looks not quite related, but actually this regression is caused by #11854.

cc @junlincc @zuzana-vej

@graceguo-supercat graceguo-supercat added P1 Priority item - Major viz:dashboard:ui labels Jan 5, 2021
@junlincc junlincc added the #bug:regression Bugs that are identified as regessions label Jan 5, 2021
@junlincc
Copy link
Member

junlincc commented Jan 5, 2021

Thanks for reporting! This new feature did introduce some regressions in both Explore and Dashboard. (i still very much value the work though @kgabryje)
@geido can you take this on just and get more familiar w Dashboard? Prioritizing it as P1 bug. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:regression Bugs that are identified as regessions P1 Priority item - Major
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants