[Explore] Time picker custom setting for timezone

[graceguo-supercat]

• In Advanced range type, user can type in time with free text (this is great! l like this design and implementation!!):

• But in Custom range type, user have to set time by click on hour/minute/second, free text will be overwritten when user close calendar.
  

• I think the 3 columns for hour/minute/second is a little extra.

• The settings for Advanced vs Custom should be consistent: one place allow user type free text, the other is not, with no obvious reason or hint from UI. When i type in time in Custom range type and then get removed , i thought it was a bug.

Environment

latest mater

@junlincc @zhaoyongjie

[junlincc]

Thanks for the nice comment for Advanced! @graceguo-supercat
much more users can do in the free text input, and it reaches full feature parity with Tableau!
if you think below would be useful for your users, pls also help test them and give us feedback 🙏 @zuzana-vej @etr2460

[junlincc]

again, thanks for the valuable feedback, we will get this enhancement done by 1.0 release.
The settings for Advanced vs Custom should be consistent

@zhaoyongjie 🙏

[graceguo-supercat]

This specifications for the new Timepicker is great. I will share with airbnb users after our next release.

[zhaoyongjie]

Hi, @graceguo-supercat. There are some UX usage issues here.

• In the Custom Frame:
  The new Datepicker(Antd Datepicker) use mouse onBlur event as shortcut to cancel value input. (so the Datepicker value cannot be saved in time)
  If you need to confirm the change, you need to use the enter key or mouse click the Ok button. (submitted Datepicker value)

Jan-07-2021.21-21-19.mp4

• For Advanced Frame vs Custom Frame consistent
  Custom Frame is just a subset of the Advanced Frame representation range, Advanced Frame has more rich datetime-expression. Datapicker in the Custom Frame only accepts YYYY-MM-DD[T]HH:mm:ss datetime style, while Advanced Frame is a free-text input box.

CC: @junlincc

[graceguo-supercat]

Thanks @zhaoyongjie I didn't realize enter key is the key :)

I have a couple of other requests:

• Midnight in Custom type:

is it Midnight UTC time zone? or user's local time zone? Is it the last midnight or the next midnight in the future? Please make it clear:

• Available date operations in Advanced type:

Advanced date type has many new operators, like `dateadd`, `datetrunc` etc, which we don't have before. We should offer a full list of feature descriptions for users. Otherwise for those non-tech background users, they don't know how to use it or how to find the secret.

So i am thinking better way to expose advanced operations, for example:

• add a big tooltip for Config Advanced Time Range, and list many usage samples like @junlincc shared, or
• something like Markdown component, it links out to a Markdown Cheatsheet.

cc @junlincc please give some suggestions?

[junlincc]

is it Midnight UTC time zone?

Yes, it's UTC time zone, and we have plan to allow user to set time zone. it's a committed enhancement in roadmap @graceguo-supercat

[junlincc]

Advanced date type has many new operators, like dateadd, datetrunc etc, which we don't have before. We should offer a full list of feature descriptions for users. Otherwise for those non-tech background users, they don't know how to use it or how to find the secret.

Yes! I am well aware of the need of adding tooltip of advanced syntax description, as I'm one of the non-tech background users😅. We will get both projects started within a couple weeks. @graceguo-supercat

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[rusackas]

Closing this as stale... the time picker has undergone a lot of redesign and reengineering since this was opened, and will continue to do so in the future. I think the most actionable parts have been handled, and any remaining bugs and issues should be handled in new/updated Issues and Discussions as is most fitting.

[ThanhTrung90]

is it Midnight UTC time zone?

Yes, it's UTC time zone, and we have plan to allow user to set time zone. it's a committed enhancement in roadmap @graceguo-supercat

@junlincc Can user set time zone in superset right now?
If yes, how can user do that?