Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[settings] List Users-> Filter changed by can be set with empty value #12443

Closed
adam-stasiak opened this issue Jan 12, 2021 · 2 comments
Closed
Labels
!deprecated-label:bug Deprecated label - Use #bug instead global:search Related to the search functionalities

Comments

@adam-stasiak
Copy link
Contributor

When I go to List Users
And Set filter Changed By with empty value (yes it is possible to choose empty value from dropdown)
Then I click Search

Expected results

I am not able to choose empty value from dropdown. When value is not set -> search operation should be not permitted.

Actual results

I can set empty value and then application got an error from backend.

Screenshots

Zrzut ekranu 2021-01-12 o 13 05 22

Nagranie.z.ekranu.2021-01-12.o.13.10.21.mov

How to reproduce the bug

  1. Go to list users
  2. add filter Changed by
  3. set empty value from dropdown
  4. click search

Environment

commit 0f731f2

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • [x ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [x ] I have reproduced the issue with at least the latest released version of superset.
  • [x ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

@adam-stasiak adam-stasiak added the #bug Bug report label Jan 12, 2021
@adam-stasiak adam-stasiak changed the title List Users-> Filter changed by can be set with empty value [settings] List Users-> Filter changed by can be set with empty value Jan 12, 2021
@junlincc junlincc removed #bug Bug report Polidea labels Jan 12, 2021
@zuzana-vej zuzana-vej added global:search Related to the search functionalities !deprecated-label:bug Deprecated label - Use #bug instead labels Apr 20, 2021
@stale
Copy link

stale bot commented May 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@rusackas
Copy link
Member

rusackas commented Feb 5, 2024

This is likely fixed by now, and is pretty out of date if not. If people are still encountering this in current versions (3.x) please open a new Issue or a PR to address the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead global:search Related to the search functionalities
Projects
None yet
Development

No branches or pull requests

4 participants