Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[explore]cosmetic improvement suggestions #12707

Closed
junlincc opened this issue Jan 23, 2021 · 3 comments · Fixed by #14495
Closed

[explore]cosmetic improvement suggestions #12707

junlincc opened this issue Jan 23, 2021 · 3 comments · Fixed by #14495
Labels
explore Namespace | Anything related to Explore need:design-review Requires input/approval from a Designer

Comments

@junlincc
Copy link
Member

junlincc commented Jan 23, 2021 •
edited
Loading

Screen Shot 2021-01-23 at 12 31 48 AM

  1. decrease the spacing between VIEW RESULTS & VIEM SAMPLES tabs and caret & section title
  2. remove the frame(including drop-shadow) around data table and chart sections
  3. move pagination down to create more space for the table

cc @mihir174
@junlincc junlincc added the explore Namespace | Anything related to Explore label Jan 23, 2021
@junlincc junlincc changed the title [explore]a few datatable cosmetic improvement [explore]a few datatable cosmetic improvement suggestions Jan 23, 2021
@junlincc junlincc added the bash! label Jan 23, 2021
@ktmud
Copy link
Member

ktmud commented Jan 23, 2021

I think all of these are already fixed by #12649 .

The only thing I still don't like about this panel is the caret and the resize bar, it seems there is a lot of waste of space that could be optimized.

@junlincc
Copy link
Member Author

junlincc commented Jan 23, 2021 •
edited
Loading

I think all of these are already fixed by #12649 .

checked again, yes - mysterious frame and drop-shadow are gone.
yup, we will kill some space between chart and the table

Screen Shot 2021-01-23 at 12 28 18 PM

@junlincc junlincc added the need:design-review Requires input/approval from a Designer label Jan 25, 2021
@junlincc junlincc changed the title [explore]a few datatable cosmetic improvement suggestions [explore]cosmetic improvement suggestions Feb 24, 2021
@geido geido mentioned this issue May 5, 2021
Merged
8 tasks
@rusackas
Copy link
Member

@junlincc Were there other issues that needed to be fixed to close this issue?

@laxmanraparthi laxmanraparthi mentioned this issue Jan 15, 2024
Open
This was referenced Mar 11, 2024
Open
Closed
@matrix-compute matrix-compute mentioned this issue Mar 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
explore Namespace | Anything related to Explore need:design-review Requires input/approval from a Designer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: White space between Chart and Data panel in Explore
3 participants
@ktmud @rusackas @junlincc