Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble Size should not be required for World Map visualization #5599

Closed
emlittleworth opened this issue Aug 9, 2018 · 3 comments
Closed
Labels
inactive Inactive for >= 30 days

Comments

@emlittleworth
Copy link
Contributor

emlittleworth commented Aug 9, 2018

  • [√ ] I have checked the superset logs for python stacktraces and included it here as text if any
  • [ √] I have reproduced the issue with at least the latest released version of superset
  • [ √] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.26.3

Expected results

I should be able to use the World Map visualization without expanding the "Bubbles" section and selecting the "Bubble size" dropdown.

Actual results

It is required even when "Show Bubbles" isn't selected. The newly added validation is useful so people don't run into issues (for example: #5171, #4371, #2361) but it doesn't make sense to enforce this when "Show Bubbles" is unchecked.

image

Steps to reproduce

Use the World Map visualization.

@Manikandan25
Copy link

Manikandan25 commented Aug 10, 2018

solve1
If you unchecked Show Bubbles, it shouldn't ask for a column to represent bubble size.
If you need the bubbles of same size, you can fill in the custom sql as 1 (or some other numbers).
If you don't need any bubbles, for now , you can fill the custom sql as 1 and uncheck the Show Bubbles.
Check the image , I have attached

@emlittleworth
Copy link
Contributor Author

Yeah I understand the workaround but created the issue because I feel the interaction should change. It'd be ideal to not have to fill in "Bubble size" if "Show Bubbles" is unchecked. The validation error in red in the screenshot I added shows that it is being enforced regardless of the state of "Show Bubbles."

@stale
Copy link

stale bot commented Apr 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

2 participants