From e3f58dcf73c5280d57cafab12537a210d125fcf3 Mon Sep 17 00:00:00 2001 From: Yongjie Zhao Date: Mon, 6 Jun 2022 11:18:04 +0800 Subject: [PATCH] chore: remove unused codes for samples --- UPDATING.md | 1 + superset-frontend/src/explore/exploreUtils/index.js | 10 +--------- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/UPDATING.md b/UPDATING.md index 866c2f95c8d72..2e000eb885661 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -27,6 +27,7 @@ assists people when migrating to a new version. - [19046](https://github.com/apache/superset/pull/19046): Enables the drag and drop interface in Explore control panel by default. Flips `ENABLE_EXPLORE_DRAG_AND_DROP` and `ENABLE_DND_WITH_CLICK_UX` feature flags to `True`. - [18936](https://github.com/apache/superset/pull/18936): Removes legacy SIP-15 interim logic/flags—specifically the `SIP_15_ENABLED`, `SIP_15_GRACE_PERIOD_END`, `SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS`, and `SIP_15_TOAST_MESSAGE` flags. Time range endpoints are no longer configurable and strictly adhere to the `[start, end)` paradigm, i.e., inclusive of the start and exclusive of the end. Additionally this change removes the now obsolete `time_range_endpoints` from the form-data and resulting in the cache being busted. - [19570](https://github.com/apache/superset/pull/19570): makes [sqloxide](https://pypi.org/project/sqloxide/) optional so the SIP-68 migration can be run on aarch64. If the migration is taking too long installing sqloxide manually should improve the performance. +- [20170](https://github.com/apache/superset/pull/20170): Introduced a new endpoint for getting datasets samples. ### Breaking Changes diff --git a/superset-frontend/src/explore/exploreUtils/index.js b/superset-frontend/src/explore/exploreUtils/index.js index d5c3d06d5f6b6..127766e7f314f 100644 --- a/superset-frontend/src/explore/exploreUtils/index.js +++ b/superset-frontend/src/explore/exploreUtils/index.js @@ -26,7 +26,6 @@ import { getChartBuildQueryRegistry, getChartMetadataRegistry, } from '@superset-ui/core'; -import { omit } from 'lodash'; import { availableDomains } from 'src/utils/hostNamesConfig'; import { safeStringify } from 'src/utils/safeStringify'; import { URL_PARAMS } from 'src/constants'; @@ -216,7 +215,7 @@ export const buildV1ChartDataPayload = ({ ...baseQueryObject, }, ])); - const payload = buildQuery( + return buildQuery( { ...formData, force, @@ -230,13 +229,6 @@ export const buildV1ChartDataPayload = ({ }, }, ); - if (resultType === 'samples') { - // remove row limit and offset to fall back to defaults - payload.queries = payload.queries.map(query => - omit(query, ['row_limit', 'row_offset']), - ); - } - return payload; }; export const getLegacyEndpointType = ({ resultType, resultFormat }) =>