diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx index 47713e69cadc9..f34b9c72d8067 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx @@ -130,6 +130,10 @@ export const DraggableFilter: FC = ({ }, }); drag(drop(ref)); + + //this is gross... we should pass in the filter/divider type, rather than inferring from the generated ID. + const filterIcon = filterIds[0].split('-')[0] == "NATIVE_FILTER" ? : ; + return ( = ({ className="dragIcon" viewBox="4 4 16 16" /> + {filterIcon}
{children}
); diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx index 8014f3bbb13d7..f61c9d6458472 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx @@ -19,8 +19,10 @@ import { useRef, FC } from 'react'; import { NativeFilterType, styled, t, useTheme } from '@superset-ui/core'; -import { AntdDropdown } from 'src/components'; -import { MainNav as Menu } from 'src/components/Menu'; +import { DropdownButton } from 'src/components/DropdownButton'; +import { DropdownButtonProps } from 'antd/lib/dropdown'; +import Icons from 'src/components/Icons'; +import { MainNav } from 'src/components/Menu'; import FilterTitleContainer from './FilterTitleContainer'; import { FilterRemoval } from './types'; @@ -58,7 +60,7 @@ const options = [ { label: t('Divider'), type: NativeFilterType.Divider }, ]; -const FilterTitlePane: FC = ({ +const FilterTitlePane: React.FC = ({ getFilterTitle, onChange, onAdd, @@ -89,27 +91,30 @@ const FilterTitlePane: FC = ({ }, 0); }; const menu = ( - - {options.map(item => ( - handleOnAdd(item.type)}> - {item.label} - - ))} - + + handleOnAdd(NativeFilterType.DIVIDER)}> + {t('Add Divider')} + + ); + + const StyledDropdownButton = styled( + DropdownButton as React.FC, + )` + padding: ${theme.gridUnit * 2}px ${theme.gridUnit * 4}px; + `; + return ( - } > - -
{' '} - {t('Add filters and dividers')} - - + handleOnAdd(NativeFilterType.NATIVE_FILTER)}> + {t('Add Filter')} + +