Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to delete a ds that has an open ds request is successful #2595

Closed
mitchell852 opened this issue Jul 27, 2018 · 1 comment · Fixed by #3727
Closed

trying to delete a ds that has an open ds request is successful #2595

mitchell852 opened this issue Jul 27, 2018 · 1 comment · Fixed by #3727
Labels
bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1

Comments

@mitchell852
Copy link
Member

mitchell852 commented Jul 27, 2018

With ds requests turned on in traffic_portal_properties.json, all changes to a ds (create, update or delete) result in the creation of a ds request.

however, if you are an admin, you can select "fulfill immediately" for the ds request. this will result in:

  1. creating a ds request to delete the ds and immediately marking it as complete
  2. deleting the ds

#1 should fail if an existing ds request is open (status != complete) for the ds which it does but #2 still succeeds (which it should not).

UPDATE:
@dsouza93 found this issue as well (#3717), the underlying issue sounds the same:

When there is an open delivery service request for a delivery service, and a user attempts to change a value on the delivery service and "fulfill immediately", Traffic Portal displays an error that there is an active delivery service request open for said delivery service. The delivery service data is then updated anyway. I am not sure if this is intended behavior and is to serve as a warning or if it supposed to prevent updates, but thought I'd bring it up.

My specific use case was when there was a delivery service request in the "pending" status with the only action left was to "complete" the request. I then set the delivery service itself to "active"/"fulfill immediately" without completing the delivery service request.

I am unsure if this will occur when other fields are altered or if it will occur when DS requests are in other states.

@jhg03a
Copy link
Contributor

jhg03a commented Jul 16, 2019

This also sounds like a duplicate of #3512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
2 participants