Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating types dynamically through the API should be limited to type where useintable=server #3728

Closed
mitchell852 opened this issue Jul 16, 2019 · 1 comment · Fixed by #4600
Labels
database relating to setup/installation/structure of the Traffic Ops database medium impact impacts a significant portion of a CDN, or has the potential to do so tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops

Comments

@mitchell852
Copy link
Member

mitchell852 commented Jul 16, 2019

The types table currently has types associated with

  • cache groups
  • delivery services
  • federations
  • regexes
  • servers
  • static dns entries
  • steering targets
  • TO extensions

as far as i know, only one type of type can be added dynamically - server types. The other types are "static" and would require supporting code changes if new types are introduced.

For example, you can create an EDGE_FOO or MID_FOO type and the system will treat those servers as edges and mids respectively because they start with EDGE or MID. no code changes required.

however, if you create a DNS_FOO delivery service type, the system can't handle that without code changes.

Therefore, I think the CRUD apis for types should only work if useintable=server. otherwise, you should get back a 400 Bad Request.

@ocket8888
Copy link
Contributor

Maybe server_type should just be its own thing? Then "Type"s could just be made totally immutable (or done away with entirely).

@mitchell852 mitchell852 added database relating to setup/installation/structure of the Traffic Ops database Traffic Ops API Next Improvements to Traffic Ops API - particularly breaking changes medium impact impacts a significant portion of a CDN, or has the potential to do so and removed Traffic Ops API Next Improvements to Traffic Ops API - particularly breaking changes labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database relating to setup/installation/structure of the Traffic Ops database medium impact impacts a significant portion of a CDN, or has the potential to do so tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants