Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delivery Services can be assigned servers from a different CDN #4116

Closed
ocket8888 opened this issue Nov 14, 2019 · 4 comments · Fixed by #4701
Closed

Delivery Services can be assigned servers from a different CDN #4116

ocket8888 opened this issue Nov 14, 2019 · 4 comments · Fixed by #4701
Labels
bug something isn't working as intended high impact impacts the basic function, deployment, or operation of a CDN Traffic Ops related to Traffic Ops

Comments

@ocket8888
Copy link
Contributor

I'm submitting a ...

  • bug report

Traffic Control components affected ...

  • Traffic Ops

Current behavior:

Similar to #3756 , the TO API allows servers to be assigned to Delivery Services outside of their respective CDNs via the endpoints:

  • deliveryservices/{{xml_id}}/servers
  • deliveryserviceserver

(and also /servers/{{ID}}/deliveryservices at the time of this writing, but that's fixed by #3761)

Expected / new behavior:

Servers outside of a Delivery Service's CDN should not be assignable to said Delivery Service.

Minimal reproduction of the problem with instructions:

  1. Create a (Edge-tier cache or Origin) Server in CDN A
  2. Create a Delivery Service in CDN B
  3. Try to assign the Server to the Delivery Service
  4. Notice how that worked even though it shouldn't.
@ocket8888 ocket8888 added bug something isn't working as intended Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one labels Nov 14, 2019
@ocket8888 ocket8888 added high impact impacts the basic function, deployment, or operation of a CDN and removed low impact affects only a small portion of a CDN, and cannot itself break one labels Nov 15, 2019
@mitchell852
Copy link
Member

just for the record, TP prevents this. When assigning DS's to a Server, only DS's in the same cdn are displayed.

@lbathina
Copy link

this is exactly duplicate of #4085 which is closed saying its duplicate of #3756 - it is not. they are two different scenarios. It shouldn't have been closed in first place.

@mitchell852
Copy link
Member

mitchell852 commented Nov 20, 2019

along the same lines, you can do the following:

  1. assign an edge server in cdn 1 to a ds in cdn 1 (which is fine and expected)
  2. update the edge server to be in cdn 2

now you have an edge cache from cdn 2 assigned to a ds in cdn 1.

image

i guess on server update, if changing the cdn value, the update should be rejected if the server is assigned to any ds's?

@rob05c
Copy link
Member

rob05c commented Nov 20, 2019

i guess on server update, if changing the cdn value, the update should be rejected if the server is assigned to any ds's?

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended high impact impacts the basic function, deployment, or operation of a CDN Traffic Ops related to Traffic Ops
Projects
None yet
4 participants