GET /servers?dsId={id} returning mid servers outside of the ds's cdn

[mitchell852]

I'm submitting a ...

• bug report

Traffic Control components affected ...

• Traffic Ops

Current behavior:

When a DS does not utilize a topology, GET /servers?dsId={id} should return ALL servers employed by the DS. This would include all direct edge or org server assignments as well as any implicitly assigned mids. However, servers outside of the ds's cdn should never be returned. Currently, mids outside the cdn are being returned.

Expected behavior:

When a DS does not utilize a topology, GET /servers?dsId={id} should return all servers employed by the DS which includes edges, orgs and mids (for certain ds types), but none of those servers should even be from a different cdn.

Minimal reproduction of the problem with instructions:

• Create an HTTP delivery service (note the ID)
• Assign a handful of edges to the DS
• Ensure that the edges are in a cachegroup with a parent cache group made up of mids
• in the parent cache group put mid servers from different cdns
• GET /servers?dsId={id} will return all the Edges plus all the Mids including the mids from the wrong cdn.