Fix cache config generation for MIDs with a cache parent and HTTPS origin #6580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob05c
added
bug
Fixes cache config remap.config generation when a server is MID type with other caches as parents in a Topology, and HTTPS origins. The bug was inserting the Origin's URI verbatim in the remap target, without changing HTTPS schemes to HTTP for the internal CDN request. This bug existed for ages, and was fixed in most other scenarios, but not this exact one.
rob05c
force-pushed
the
fix-t3c-mid-cache-parent-https-ds-remap
branch
from
50b2eb0
to
0b4b181
Compare
rob05c
changed the title
rob05c
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cache config remap.config generation when a server is MID type
with other caches as parents in a Topology, and HTTPS origins.
The bug was inserting the Origin's URI verbatim in the remap target,
without changing HTTPS schemes to HTTP for the internal CDN request.
This bug existed for ages, and was fixed in most other scenarios,
but not this exact one.
Note the corresponding parent.config line correctly expects http/80.
The bug is only in remap.config generation.
Includes tests.
Includes changelog.
No docs, no interface change.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run tests. Create a Topology with a MID-type server, with other caches as parents, and assign it to a Delivery Service with an HTTPS origin. Verify generated remap.config has an
httptarget, nothttps.If this is a bugfix, which Traffic Control versions contained the bug?
Bug has existed forever.
PR submission checklist
- [x] This PR has documentationNo docs, no interface change