Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic Stats should use TO API v3 #6694

Closed
rawlinp opened this issue Mar 25, 2022 · 5 comments · Fixed by #6844
Closed

Traffic Stats should use TO API v3 #6694

rawlinp opened this issue Mar 25, 2022 · 5 comments · Fixed by #6844
Assignees
Labels
improvement The functionality exists but it could be improved in some way. low difficulty the estimated level of effort to resolve this issue is low tech debt rework due to choosing easy/limited solution Traffic Stats related to Traffic Stats
Milestone

Comments

@rawlinp
Copy link
Contributor

rawlinp commented Mar 25, 2022

This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components:

  • Traffic Stats

Current behavior:

Traffic Stats uses TO API v2.

New behavior:

Traffic Stats should use TO API v3, since that is the current stable TO API version, and TO API v2 is being removed.

@rawlinp rawlinp added Traffic Stats related to Traffic Stats tech debt rework due to choosing easy/limited solution improvement The functionality exists but it could be improved in some way. labels Mar 25, 2022
@rawlinp rawlinp added this to the 7.0.0 milestone Mar 25, 2022
@mitchell852
Copy link
Member

@rawlinp can you put an effort level on this if you know it?

@rawlinp rawlinp added the low difficulty the estimated level of effort to resolve this issue is low label Mar 29, 2022
@mitchell852
Copy link
Member

maybe this can be done after 4.x is stabiized allowing us to move TS to 4.x rather than 3.x which is soon to be deprecated :)

@rawlinp
Copy link
Contributor Author

rawlinp commented Apr 13, 2022

That means we can't remove API 2.x until 4.x is stabilized, but maybe we're ok with that? Either way, for TS, this is a really low effort change.

@jhowar201
Copy link
Contributor

Will take a look at this.

@ocket8888
Copy link
Contributor

If we put this on the 6.2.0 milestone instead of 7.0.0 then we can still get rid of APIv2 at the same time as stabilizing v4. We'd need to wait for 7.0.1, minimum, to update TS to using APIv4, though, since it doesn't properly fall back. Unless we don't care about breaking Stats deployments across the major version boundary a la TP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement The functionality exists but it could be improved in some way. low difficulty the estimated level of effort to resolve this issue is low tech debt rework due to choosing easy/limited solution Traffic Stats related to Traffic Stats
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants