Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELETE servers/{{ID}} response with an APIv4 server representation regardless of the requested version #6907

Closed
ocket8888 opened this issue Jun 17, 2022 · 1 comment · Fixed by #6932
Assignees
Labels
low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops

Comments

@ocket8888
Copy link
Contributor

This Bug Report affects these Traffic Control components:

  • Traffic Ops

Current behavior:

When deleting a server, the response will be an APIv4 representation of the server, regardless of the version of the API used in the request. This is a breaking change to that API endpoint in violation of our versioning contract.

Expected behavior:

The requested API version should be used to determine the response.

Steps to reproduce:

# Replace the typeId, cdnId, statusId, physLocationId, and cachegroupId
# with whatever values are valid for your Traffic Ops installation.
ID=$(topost -ka 3.1 servers '{
	"interfaces": [
		{
			"name": "eth0",
			"ipAddresses": [
				{
					"address": "127.0.0.1",
					"serviceAddress": true
				}
			]
		}
	],
	"typeId": 11,
	"statusId": 1,
	"cachegroupId": 1,
	"profileId": 10,
	"cdnId": 2,
	"physLocationId": 1,
	"domainName": "test",
	"hostName": "quest"
}' | jq '.response.id')
todelete -kpa 3.1 "servers/$ID"
@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one regression bug a bug in existing functionality introduced by a new version low difficulty the estimated level of effort to resolve this issue is low labels Jun 17, 2022
@ocket8888
Copy link
Contributor Author

This doesn't actually appear to affect APIv2, only 3.0 and 3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants