Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change t3c sni.yaml disable_h2 to http2 directive
ATS 9 is documented as allowing the disable_h2 directive in sni.yaml
(albiet deprecated). But it doesn't seem to work.
This changes cache config gen to generate the newer http2 directive
instead.
I'm labelling
bug
because even though this isn't a bug per the ATS documentation, it appears to create a behavioral bug in-practice.Which Traffic Control components are affected by this PR?
t3c
, formerly ORT)What is the best way to verify this PR?
Generate cache config, verify sni.yaml has
http2:
directives instead ofdisable_h2
directives. Run ATS 9 with generated config, verify ATS enables or disables H2 appropriately.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist
[x] This PR has documentationno docs, details of cache config generated files are not documented