Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add t3c flag for local ATS version for config gen #7032

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

rob05c
Copy link
Member

@rob05c rob05c commented Aug 22, 2022

Adds a new t3c-apply --local-ats-version flag to discover and use the local installed ATS version for config generation, rather than the Traffic Ops Server package Parameter.

This, combined with the existing --install-packages=false flag, allows users to manage the ATS operating system package with an external tool (e.g. Ansible, Puppet, etc).

Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)

What is the best way to verify this PR?

Run tests. Run t3c-apply with the new --local-ats-version flag with a local installed Traffic server major version different from any Server Package Parameter, verify local ATS version is used to generate rather than package Parameter.

If this is a bugfix, which Traffic Control versions contained the bug?

Not a bug fix.

PR submission checklist

@rob05c rob05c added new feature A new feature, capability or behavior medium impact impacts a significant portion of a CDN, or has the potential to do so cache-config Cache config generation labels Aug 22, 2022
@rob05c rob05c force-pushed the add-t3c-ats-version-flag branch 3 times, most recently from e7d8c65 to f5be26f Compare August 22, 2022 23:19
lib/go-atscfg/atscfg.go Fixed Show fixed Hide fixed
Copy link
Contributor

@jpappa200 jpappa200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me, tests passed.

@ocket8888 ocket8888 merged commit 3b21783 into apache:master Aug 26, 2022
zrhoffman pushed a commit to zrhoffman/trafficcontrol that referenced this pull request Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cache-config Cache config generation medium impact impacts a significant portion of a CDN, or has the potential to do so new feature A new feature, capability or behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants