Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed CiaB build issue #4251

Merged
merged 2 commits into from
Jan 3, 2020
Merged

Fixed CiaB build issue #4251

merged 2 commits into from
Jan 3, 2020

Conversation

ocket8888
Copy link
Contributor

@ocket8888 ocket8888 commented Jan 2, 2020 •
edited
Loading

What does this PR (Pull Request) do?

Instead of download the Maxmind database, this PR changes the TO Perl build for CiaB to use the database that's bundled into the Traffic Router test package.

Which Traffic Control components are affected by this PR?

  • CDN in a Box

What is the best way to verify this PR?

Build CDN-in-a-Box, notice no errors and that TR works

If this is a bug fix, what versions of Traffic Control are affected?

  • master
  • 4.0.0 (RC1)

The following criteria are ALL met by this PR

  • Tests are unnecessary
  • Documentation is unnecessary
  • An update to CHANGELOG.md is not necessary
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added bug something isn't working as intended high impact impacts the basic function, deployment, or operation of a CDN cdn-in-a-box related to the Docker-based CDN-in-a-Box system labels Jan 2, 2020
mhoppa
mhoppa approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@mhoppa mhoppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested okay locally

@mitchell852 mitchell852 merged commit 78e6680 into apache:master Jan 3, 2020
@ocket8888 ocket8888 deleted the ciab-build-fix branch January 3, 2020 16:12
ocket8888 added a commit to ocket8888/trafficcontrol that referenced this pull request Jan 9, 2020
@ocket8888
Fixed CiaB build issue (apache#4251)
bb16d5c 
* Fixed CiaB build issue

* Removed commented-out lines

(cherry picked from commit 78e6680)
@ocket8888 ocket8888 mentioned this pull request Jan 9, 2020
Merged
7 tasks
rawlinp pushed a commit that referenced this pull request Jan 9, 2020
@ocket8888 @rawlinp
Fixed CiaB build issue (#4251) (#4270)
b6f52aa 
* Fixed CiaB build issue

* Removed commented-out lines

(cherry picked from commit 78e6680)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhoppa mhoppa mhoppa approved these changes

Assignees
No one assigned
Labels
bug something isn't working as intended cdn-in-a-box related to the Docker-based CDN-in-a-Box system high impact impacts the basic function, deployment, or operation of a CDN
Projects
None yet
Milestone
No milestone
3 participants
@ocket8888 @mhoppa @mitchell852