From 517b034fe8bad09d7c44373254f53c62c0e8aeea Mon Sep 17 00:00:00 2001 From: Rima Shah Date: Tue, 8 Nov 2022 11:11:08 -0700 Subject: [PATCH 1/2] Fixed value from a formatter to a getter. --- CHANGELOG.md | 1 + .../TableDeliveryServicesController.js | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b913e1904f..02bcb410b4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,6 +28,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - [#7037](https://github.com/apache/trafficcontrol/pull/7037) *Traffic Router* Uses Traffic Ops API 4.0 by default ### Fixed +- *Traffic Portal* Fixed filter search for Delivery Service Table - *Traffic Portal* Fixed topologies sort (table and Delivery Service's form) - [#5970](https://github.com/apache/trafficcontrol/issues/5970) *Traffic Portal* Fixed numeric sort in Delivery Service's form for DSCP - [#5971](https://github.com/apache/trafficcontrol/issues/5971) *Traffic Portal* Fixed Max DNS Tool Top link to open in a new page diff --git a/traffic_portal/app/src/common/modules/table/deliveryServices/TableDeliveryServicesController.js b/traffic_portal/app/src/common/modules/table/deliveryServices/TableDeliveryServicesController.js index 3b10e100ac..aacc2571d4 100644 --- a/traffic_portal/app/src/common/modules/table/deliveryServices/TableDeliveryServicesController.js +++ b/traffic_portal/app/src/common/modules/table/deliveryServices/TableDeliveryServicesController.js @@ -122,7 +122,7 @@ function TableDeliveryServicesController(tableName, deliveryServices, steeringTa headerName: "Geo Limit", field: "geoLimit", hide: true, - valueFormatter: params => deliveryServiceUtils.geoLimits[params.data.geoLimit], + valueGetter: params => deliveryServiceUtils.geoLimits[params.data.geoLimit], tooltipValueGetter: params => deliveryServiceUtils.geoLimits[params.data.geoLimit] }, { @@ -139,7 +139,7 @@ function TableDeliveryServicesController(tableName, deliveryServices, steeringTa headerName: "Geolocation Provider", field: "geoProvider", hide: true, - valueFormatter: params => deliveryServiceUtils.geoProviders[params.data.geoProvider], + valueGetter: params => deliveryServiceUtils.geoProviders[params.data.geoProvider], tooltipValueGetter: params => deliveryServiceUtils.geoProviders[params.data.geoProvider] }, { @@ -261,21 +261,21 @@ function TableDeliveryServicesController(tableName, deliveryServices, steeringTa headerName: "Protocol", field: "protocol", hide: false, - valueFormatter: params => deliveryServiceUtils.protocols[params.data.protocol], + valueGetter: params => deliveryServiceUtils.protocols[params.data.protocol], tooltipValueGetter: params => deliveryServiceUtils.protocols[params.data.protocol] }, { headerName: "Qstring Handling", field: "qstringIgnore", hide: true, - valueFormatter: params => deliveryServiceUtils.qstrings[params.data.qstringIgnore], + valueGetter: params => deliveryServiceUtils.qstrings[params.data.qstringIgnore], tooltipValueGetter: params => deliveryServiceUtils.qstrings[params.data.qstringIgnore] }, { headerName: "Range Request Handling", field: "rangeRequestHandling", hide: true, - valueFormatter: params => deliveryServiceUtils.rrhs[params.data.rangeRequestHandling], + valueGetter: params => deliveryServiceUtils.rrhs[params.data.rangeRequestHandling], tooltipValueGetter: params => deliveryServiceUtils.rrhs[params.data.rangeRequestHandling] }, { From 61b131731f4dee253c89c419d76b941de8f7ea72 Mon Sep 17 00:00:00 2001 From: Rima Shah Date: Tue, 8 Nov 2022 11:13:44 -0700 Subject: [PATCH 2/2] Updated Changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 02bcb410b4..280b7dcb92 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,7 +28,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - [#7037](https://github.com/apache/trafficcontrol/pull/7037) *Traffic Router* Uses Traffic Ops API 4.0 by default ### Fixed -- *Traffic Portal* Fixed filter search for Delivery Service Table +- *Traffic Portal* Fixed search filter for Delivery Service Table - *Traffic Portal* Fixed topologies sort (table and Delivery Service's form) - [#5970](https://github.com/apache/trafficcontrol/issues/5970) *Traffic Portal* Fixed numeric sort in Delivery Service's form for DSCP - [#5971](https://github.com/apache/trafficcontrol/issues/5971) *Traffic Portal* Fixed Max DNS Tool Top link to open in a new page