Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TVM][ARITH] integer set analysis does not handle Select #2686

Closed
derisavi opened this issue Feb 27, 2019 · 2 comments · Fixed by #2687
Closed

[TVM][ARITH] integer set analysis does not handle Select #2686

derisavi opened this issue Feb 27, 2019 · 2 comments · Fixed by #2687

Comments

@derisavi
Copy link
Contributor

When faced with Select operator, IntSetEvaluator will do the default thing which is to return IntSet::everything() which is too conservative.
The right thing to do is to return the union of IntSets of true and false expressions.

@tqchen
Copy link
Member

tqchen commented Feb 27, 2019

This sounds like something we can directly send a patch to fix, we can also consolidate it to #2588

I have already done so for some of the analysis in #2668

@derisavi
Copy link
Contributor Author

I already have a fix (5 lines of code) for this small bug. I was going to send a PR but I'm open to suggestion on what do with it (or even not to do anything with it and wait for a PR for #2588)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants