Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NNVM][RFC] Begin the removal of NNVM Compiler #4496

Closed
jroesch opened this issue Dec 10, 2019 · 7 comments
Closed

[NNVM][RFC] Begin the removal of NNVM Compiler #4496

jroesch opened this issue Dec 10, 2019 · 7 comments

Comments

@jroesch
Copy link
Member

jroesch commented Dec 10, 2019

After one cycle of deprecation it is now time to start the removal of legacy NNVM code. NNVM's existence in the repo is preventing some refactoring to occur for @icemelon9's new dynamically sized kernel generation work.

I know we still have some external consumers of NNVM and we should be mindful of removing things in the correct order. If we could start a discussion to collect maintenance requirements before starting to remove NNVM would be great, then we can implement the action plan over the course of the next few weeks.

@masahi
Copy link
Member

masahi commented Dec 11, 2019

Our rust code uses NNVM for testing and a usage document. They need to be updated.

@tmoreau89
Copy link
Contributor

VTA's dependence on NNVM (#4419) has mostly been removed; documentation and CI dockerfiles have to be updated to reflect this.

@tqchen tqchen changed the title [NNVM][RFC] Begin the removal of NNVM. [NNVM][RFC] Begin the removal of NNVM Compiler Dec 11, 2019
@tqchen
Copy link
Member

tqchen commented Dec 11, 2019

NOTE, we will only remove the nnvm compiler component, as mxnet's still makes use the core data structures.

@tqchen
Copy link
Member

tqchen commented Dec 17, 2019

#4535 removes the dependencies in apps, rust

@tqchen
Copy link
Member

tqchen commented Dec 22, 2019

#4562

@tqchen
Copy link
Member

tqchen commented Dec 23, 2019

#4571

@tqchen tqchen closed this as completed Dec 24, 2019
@tqchen
Copy link
Member

tqchen commented Dec 24, 2019

NNVM compiler is removed from the mainline as of #4571 The core nnvm data structures still will be maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants