-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WINDOWS] Fix python exception Creation in Windows #4529
Comments
see #2838 it will automatically translate to the corresponding error in the python side. For further development related discussions, please open a new thread on https://discuss.tvm.ai/:) |
In fact, on windows, it wont. |
hmm, interesting finding. This might be a bug that we can fix, could relates to \n \r difference |
reopen and label as help wanted, @kice can you dig a bit further? |
Here return C error string
I would suggest split the c error string into tokens by I think we should add a api to query which kind of error was happened, instead of checking the error string. But base on my analysis, this should also happen on Linux. Wired. |
Here is the code that normalizes the error message https://github.com/apache/incubator-tvm/blob/master/src/runtime/c_runtime_api.cc#L203 which will removes the header, but somehow fails your case |
Looks like the |
@kice would you like to propose a fix ? |
I would suggect to change the path on windows to unix like. So change the code in dmlc logging module? Add a constexpr to do the style conversion. |
I think the main fix could be in the NormalizeError function to fix the windows case if possible |
https://github.com/apache/incubator-tvm/blob/8e3b5d39c388f6767a2e69afff27eac55557567e/python/tvm/autotvm/task/task.py#L192
Looks like the C++ code dose not raise
AttributeError
, it just print the message.https://github.com/apache/incubator-tvm/blob/8e3b5d39c388f6767a2e69afff27eac55557567e/src/node/reflection.cc#L108-L111
Should we print the message or raise a error?
ref: #2279
The text was updated successfully, but these errors were encountered: