Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in number of pooling ops? #3

Open
gpleiss opened this issue Sep 28, 2016 · 3 comments
Open

Error in number of pooling ops? #3

gpleiss opened this issue Sep 28, 2016 · 3 comments

Comments

@gpleiss
Copy link
Contributor

gpleiss commented Sep 28, 2016

I think there might be a mistake in the pooling op count. Right now in ops_pooling, the number of operations is independent of the number of input planes. I think that the number returned should be multiplied by the number of input planes.
@liuzhuang13
Copy link

liuzhuang13 commented Oct 1, 2016 •
edited
Loading

@gpleiss , hi geoff I happened to use this code too! I manually computed flops of a model using python script, and only the result of pooling is significantly different from this code. Great to see you pointed out the bugs.

@apaszke
Copy link
Owner

apaszke commented Oct 1, 2016

Yes, you're right, it's incorrect. Would you like to send a PR?

@gpleiss
Copy link
Contributor Author

gpleiss commented Oct 5, 2016

Can do!

@gpleiss gpleiss mentioned this issue Oct 5, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gpleiss @apaszke @liuzhuang13