Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to keep the existing navigation controller? #24

Open
civilordergone opened this issue Oct 6, 2016 · 8 comments
Open
Assignees
Labels

Comments

@civilordergone
Copy link

civilordergone commented Oct 6, 2016

When I implement this sidebar, it removes the navigation bar. I know you have the option to create a topviewcontroller, but it'd be really great to keep the nav stack / bar

@aperechnev
Copy link
Owner

When I implement this sidebar, it removes the sidebar.

Do you mean it removes the navigation bar?

@civilordergone
Copy link
Author

civilordergone commented Oct 6, 2016

Yeah whoops, it's early in the morning :) I love this plugin though btw! It's very slick

@aperechnev
Copy link
Owner

aperechnev commented Oct 6, 2016

Actually the SidebarOverlay is root view controller, that contains the side menu and top view controller that is currently presented for user. If you need to push top view controller to a navigation stack, you may set UINavigationController as a top view controller for menu item:

MenuItem1 -> UINavigationController1 -> Screen1
MenuItem2 -> UINavigationController2 -> Screen2
// etc.

@aperechnev aperechnev self-assigned this Oct 6, 2016
@civilordergone
Copy link
Author

@aperechnev, so there was already a UINavigationController, then a Child ViewController (Let's call it VC_A).

VC_A's was pushed onto the first parent VC and contained the navigation bar. I updated VC_A to inherit the SideBarOverlay. When I set the SideBarVC, it loses the nav controller. If I don't set the SideBarVC, but if it still inherits SideBarOverlay, it'll display the navigation bar. What would I have to do so the nav shows up? Are you saying the SideBarVC should be pushed onto the Nav Controller too?

@aperechnev
Copy link
Owner

@civilordergone okay, almost half an year later I understood what you mean 😄 I'll try to check it out on this weekend.

@civilordergone
Copy link
Author

Haha, thanks @aperechnev for taking a look into it :D

@aperechnev aperechnev modified the milestone: 4.2 Mar 1, 2017
@kristoff2016
Copy link

How is it going on ? it is fixed ? Very nice plugin 👍

@aperechnev
Copy link
Owner

Let me a few days, I have no internet yet. I'll try to implement it on this weekend.

@aperechnev aperechnev removed this from the 4.2 milestone Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants