Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax engine specification for pre/post-processing #1544

Closed
Tracked by #1610
bbenligiray opened this issue Nov 17, 2022 · 8 comments · Fixed by #1652
Closed
Tracked by #1610

Relax engine specification for pre/post-processing #1544

bbenligiray opened this issue Nov 17, 2022 · 8 comments · Fixed by #1652
Assignees
Milestone

Comments

@bbenligiray
Copy link
Member

Currently pre/post-processing snippets require the node version to be specified. We're also constantly updating the Airnode node version. For a lack of a better alternative, I suggest dropping the node version (so node or node.js instead of node14). The alternative is to deploy multiple pre/post-processing environments for these to be run on, but even this is not a permanent solution because node versions fall out of support and cloud providers stop providing these even earlier than that.

@dcroote
Copy link
Contributor

dcroote commented Feb 8, 2023

We're also constantly updating the Airnode node version.

You don't think we'll stay on 18 for a while after #1631?

@Siegrift
Copy link
Contributor

Siegrift commented Feb 8, 2023

These versions are supported roughly for ~2years, so they are not permanent.

I support the idea of dropping the node version from processing name and use whatever node the Airnode was deployed on. Other alternatives don't seem feasible to me.

@dcroote
Copy link
Contributor

dcroote commented Feb 11, 2023

Blocked by api3dao/ois#65 and a subsequent OIS release.

@aTeoke
Copy link

aTeoke commented Feb 20, 2023

Hey, I was trying to test this via coingecko-pre-processing example, but got this error.

Error details:
2023-02-20T16:29:56.218Z ✖ Invalid Airnode configuration file: [
  {
    "code": "custom",
    "message": "oisFormat major.minor version must match major.minor version of \"1.4.0\"",
    "path": [
      "ois",
      0,
      "oisFormat"
    ]
  },
  {
    "code": "invalid_union",
    "unionErrors": [
      {
        "issues": [
          {
            "code": "invalid_literal",
            "expected": "Node 14",
            "path": [
              "ois",
              0,
              "endpoints",
              0,
              "preProcessingSpecifications",
              0,
              "environment"
            ],
            "message": "Invalid literal value, expected \"Node 14\""
          }
        ],
        "name": "ZodError"
      },
      {
        "issues": [
          {
            "code": "invalid_literal",
            "expected": "Node 14 async",
            "path": [
              "ois",
              0,
              "endpoints",
              0,
              "preProcessingSpecifications",
              0,
              "environment"
            ],
            "message": "Invalid literal value, expected \"Node 14 async\""
          }
        ],
        "name": "ZodError"
      }
    ],
    "path": [
      "ois",
      0,
      "endpoints",
      0,
      "preProcessingSpecifications",
      0,
      "environment"
    ],
    "message": "Invalid input"
  }
]

@dcroote could you please help?

@dcroote
Copy link
Contributor

dcroote commented Feb 20, 2023

Sure. For testing a new feature recently merged to master, you need to use one of the -dev Docker images and the appropriate commit sha. For this feature I would suggest the merge commit of #1652 , which is b2f1edfad867bb027f845b3dd2d601258ba7091d. With that, refer to the airnode-examples README for how to use either the api3/airnode-deployer-dev or api3/airnode-client-dev image and sha depending on whether you're deploying to a cloud provider or running locally, respectively. An example of the former would be yarn deploy-airnode api3/airnode-deployer-dev:b2f1edfad867bb027f845b3dd2d601258ba7091d

@aTeoke
Copy link

aTeoke commented Feb 21, 2023

another error during deploying requester - cannot estimate gas

Image

@aTeoke
Copy link

aTeoke commented Feb 21, 2023

fixed the issue above, tested it via coingecko-pre-processing example, worked ok

@dcroote
Copy link
Contributor

dcroote commented Feb 21, 2023

fixed the issue above, tested it via coingecko-pre-processing example, worked ok

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants