Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write proper unit tests for deployer #1568

Open
aTeoke opened this issue Dec 1, 2022 · 0 comments
Open

Write proper unit tests for deployer #1568

aTeoke opened this issue Dec 1, 2022 · 0 comments

Comments

@aTeoke
Copy link

aTeoke commented Dec 1, 2022

Currently, only a fraction of deployer’s functionality is tested. Granted, we won’t be able to test the deployment itself (that will be most likely mocked) but proper argument handling and passing can be tested.
Notes by Emanuel:

  • Also, what should be tested is the deployer CLI output and error handling.
  • You can mock the outputs of the deployments with some fixtures obtained from failed deployments (just run GCP a few times to get some).
  • What I consider the most important is reasonable format of the error descriptions which is presented to the user.
  • Also rename the test directory from “__ test__” to “test“
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant