Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dredd does not change fullPath in console output #933

Open
samekmichal opened this issue Dec 7, 2017 · 1 comment
Open

Dredd does not change fullPath in console output #933

samekmichal opened this issue Dec 7, 2017 · 1 comment

Comments

@samekmichal
Copy link

Describe your problem

When changing fullpath in a hook, the change is not reflected in the console output dredd is producing. It outputs an example value of the path parameter found in the API specification.

Example: In one of my "before" hooks I adjust the fullPath as follows (python)

@dredd.before("Tasks > Task attachment upload metadata")
def before_task_attachment_create(transaction):
    transaction["fullPath"] = "/api/v3/tasks/{}/attachments".format("abcdefgh")

However, the console output still says

fail: POST (201) /tasks/respective_task_uuid/attachments duration: 211ms

What's your dredd --version output?

dredd v4.6.2 (Darwin 17.2.0; x64)
@honzajavorek
Copy link
Contributor

Thanks! This is something related to issues with the transaction object duality (transaction vs transaction.test) and with the revamp of the CLI reporter proposed in #765. However, both are rather big areas to tackle, so if someone sends a PR with a hot fix, it would be warmly welcomed 🙂

@honzajavorek honzajavorek modified the milestone: Improve CLI output Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants