Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-seal the root context #22

Closed
gbrail opened this issue Oct 18, 2013 · 1 comment
Closed

Un-seal the root context #22

gbrail opened this issue Oct 18, 2013 · 1 comment
Labels
enhancement

Comments

@gbrail
Copy link
Contributor

gbrail commented Oct 18, 2013

In order to save memory and start up time, each NodeEnvironment creates a single Rhino context that contains all the standard objects (String, Date, etc) and "seals" it so that these cannot be modified. It then shares them between all scripts.

However, lots of Node scripts like to modify these things. We should stop doing this, and incur the cost of calling "initStandardObjects" for each script, and not trying to share a global root.
@gbrail
Copy link
Contributor Author

gbrail commented Jan 23, 2014

Released in 0.6.9.

@gbrail gbrail closed this as completed Jan 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gbrail