Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback for ClassShutter whitelist #45

Closed
gbrail opened this issue Mar 7, 2014 · 3 comments
Closed

Add callback for ClassShutter whitelist #45

gbrail opened this issue Mar 7, 2014 · 3 comments

Comments

@gbrail
Copy link
Contributor

gbrail commented Mar 7, 2014

By default, Trireme uses the Rhino ClassShutter to explicitly reject access to any Java classes other than ones that Trireme needs to do its work. However, some applications that embed trireme actually want to use other Java classes, and we need to create a way to extend Trireme to allow that.

Options are adding a callback to Sandbox that Trireme can call from its ClassShutter, or allowing the user to pass a Set of class names, or regexps for that matter.

@whitlockjc
Copy link
Member

I think a callback would be ideal. Allow the implementor to dictate how they do it.

@whitlockjc
Copy link
Member

I've submitted a pull request: #46

@gbrail
Copy link
Contributor Author

gbrail commented Mar 25, 2014

Fixed in 0.7.1.

@gbrail gbrail closed this as completed Mar 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants