Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot replace process.argv #63

Closed
ForNeVeR opened this issue Jun 15, 2014 · 3 comments
Closed

Cannot replace process.argv #63

ForNeVeR opened this issue Jun 15, 2014 · 3 comments

Comments

@ForNeVeR
Copy link

Nodejs allows user to replace process.argv vector, but Trireme does not.
Create simple test.js file:

console.log(process.argv);
process.argv = [];
console.log(process.argv);

After that:

> node test.js
[ 'C:\\Program Files\\nodejs\\node.exe', 'T:\\Temp\\test.js' ]
[]
> java -jar trireme.0.7.5.jar test.js
[ './node', 'T:\\Temp\\test.js' ]
[ './node', 'T:\\Temp\\test.js' ]

This blocks us from replacing the environment, for example, for the typescript compiler (which currently takes arguments only from process.argv).

@gbrail
Copy link
Contributor

gbrail commented Jun 16, 2014

This is easy to fix -- testing a fix now.

Is this holding something up? I have some other changes staged to go in to a release, and wondering when it makes sense to do that.

@ForNeVeR
Copy link
Author

No, this isn't holding anything for me. You may follow your standard
release schedule. And thank you for support.

@gbrail
Copy link
Contributor

gbrail commented Jul 19, 2014

Fixed in 0.8.0.

@gbrail gbrail closed this as completed Jul 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants