Missing ZenObservable module.

[Esemesek]

Intended outcome:

I was just trying to upgrade to apollo-client ^2.0.0.

My tsconfig.json

{
  "compilerOptions": {
    "target": "esnext",
    "module": "commonjs",
    "outDir": "./build/dist",
    "rootDir": "./src",
    "strict": true,
    "moduleResolution": "node",
    "allowSyntheticDefaultImports": true
  },
  "exclude": [
    "node_modules"
  ],
  "compileOnSave": true
}

Actual outcome:

$ gulp start
[19:48:46] Using gulpfile ~/projects/loud_cloud/ldc_node/gulpfile.js
[19:48:46] Starting 'graphql-copy'...
[19:48:46] Finished 'graphql-copy' after 20 ms
[19:48:46] Starting 'compile'...
/home/kacper/projects/loud_cloud/ldc_node/node_modules/apollo-client/util/Observable.d.ts(1,23): error TS2688: Cannot find type definition file for 'zen-observable'.
/home/kacper/projects/loud_cloud/ldc_node/node_modules/apollo-client/util/Observable.d.ts(3,36): error TS2503: Cannot find namespace 'ZenObservable'.
/home/kacper/projects/loud_cloud/ldc_node/node_modules/apollo-client/util/Observable.d.ts(4,35): error TS2503: Cannot find namespace 'ZenObservable'.
/home/kacper/projects/loud_cloud/ldc_node/node_modules/apollo-link-http/lib/httpLink.d.ts(1,23): error TS2688: Cannot find type definition file for 'zen-observable'.
/home/kacper/projects/loud_cloud/ldc_node/node_modules/apollo-link/lib/index.d.ts(4,29): error TS7016: Could not find a declaration file for module 'zen-observable'. '/home/kacper/projects/loud_cloud/ldc_node/node_modules/zen-observable/index.js' implicitly has an 'any' type.
  Try `npm install @types/zen-observable` if it exists or add a new declaration (.d.ts) file containing `declare module 'zen-observable';`
/home/kacper/projects/loud_cloud/ldc_node/node_modules/apollo-link/lib/link.d.ts(1,23): error TS2688: Cannot find type definition file for 'zen-observable'.
/home/kacper/projects/loud_cloud/ldc_node/node_modules/apollo-link/lib/link.d.ts(2,29): error TS7016: Could not find a declaration file for module 'zen-observable'. '/home/kacper/projects/loud_cloud/ldc_node/node_modules/zen-observable/index.js' implicitly has an 'any' type.
  Try `npm install @types/zen-observable` if it exists or add a new declaration (.d.ts) file containing `declare module 'zen-observable';`
/home/kacper/projects/loud_cloud/ldc_node/node_modules/apollo-link/lib/linkUtils.d.ts(1,23): error TS2688: Cannot find type definition file for 'zen-observable'.
/home/kacper/projects/loud_cloud/ldc_node/node_modules/apollo-link/lib/linkUtils.d.ts(2,29): error TS7016: Could not find a declaration file for module 'zen-observable'. '/home/kacper/projects/loud_cloud/ldc_node/node_modules/zen-observable/index.js' implicitly has an 'any' type.
  Try `npm install @types/zen-observable` if it exists or add a new declaration (.d.ts) file containing `declare module 'zen-observable';`
/home/kacper/projects/loud_cloud/ldc_node/node_modules/apollo-link/lib/types.d.ts(1,23): error TS2688: Cannot find type definition file for 'zen-observable'.
/home/kacper/projects/loud_cloud/ldc_node/node_modules/apollo-link/lib/types.d.ts(2,29): error TS7016: Could not find a declaration file for module 'zen-observable'. '/home/kacper/projects/loud_cloud/ldc_node/node_modules/zen-observable/index.js' implicitly has an 'any' type.
  Try `npm install @types/zen-observable` if it exists or add a new declaration (.d.ts) file containing `declare module 'zen-observable';`
[19:48:49] TypeScript: 11 semantic errors
[19:48:49] TypeScript: emit succeeded (with errors)

How to reproduce the issue:

Version

• [email protected]

I can fix it just by adding zen-observable and types/zen-observable, but I don't want to.

[KeithGillette]

I encountered the same issue with [email protected]. I was able to work around it by adding @types/zen-observable to my project.

[sheeldotme]

This was the solution in apollo-link: apollographql/apollo-link#163

[jbaxleyiii]

@Esemesek @KeithGillette @sheeldotme would any of you be able to open a PR adding these types to the deps instead of dev deps?

[Esemesek]

Created PR - #2442