From 5e6bbd9a6c72a336979fba731faa12e451447b54 Mon Sep 17 00:00:00 2001 From: Owen Allen Date: Thu, 19 Aug 2021 09:47:14 -0700 Subject: [PATCH 1/3] Sets experimental_approximateDocumentStoreMiB so it functions in initializeDocumentStore(). --- packages/apollo-server-core/src/ApolloServer.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/apollo-server-core/src/ApolloServer.ts b/packages/apollo-server-core/src/ApolloServer.ts index c580a29ebf9..9bbf996fcad 100644 --- a/packages/apollo-server-core/src/ApolloServer.ts +++ b/packages/apollo-server-core/src/ApolloServer.ts @@ -177,6 +177,7 @@ export class ApolloServerBase< this.parseOptions = parseOptions; this.context = context; + this.experimental_approximateDocumentStoreMiB = experimental_approximateDocumentStoreMiB; // Allow tests to override process.env.NODE_ENV. As a bonus, this means // we're only reading the env var once in the constructor, which is faster From 3ed241cd875e255a5f34771de46f9c6c07212cfb Mon Sep 17 00:00:00 2001 From: Owen Allen Date: Thu, 19 Aug 2021 10:31:46 -0700 Subject: [PATCH 2/3] Makes prettier happy. --- packages/apollo-server-core/src/ApolloServer.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/apollo-server-core/src/ApolloServer.ts b/packages/apollo-server-core/src/ApolloServer.ts index 9bbf996fcad..64e3795b786 100644 --- a/packages/apollo-server-core/src/ApolloServer.ts +++ b/packages/apollo-server-core/src/ApolloServer.ts @@ -177,7 +177,8 @@ export class ApolloServerBase< this.parseOptions = parseOptions; this.context = context; - this.experimental_approximateDocumentStoreMiB = experimental_approximateDocumentStoreMiB; + this.experimental_approximateDocumentStoreMiB = + experimental_approximateDocumentStoreMiB; // Allow tests to override process.env.NODE_ENV. As a bonus, this means // we're only reading the env var once in the constructor, which is faster From 842d56f368dcebae716becc6fe70758c25204404 Mon Sep 17 00:00:00 2001 From: David Glasser Date: Thu, 19 Aug 2021 11:40:08 -0700 Subject: [PATCH 3/3] CHANGELOG update --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index aebe46bc41d..e47e4937cdb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ The version headers in this history reflect the versions of Apollo Server itself ## vNEXT -- _Nothing yet! Stay tuned!_ +- `apollo-server-core`: Fix `experimental_approximateDocumentStoreMiB` option, which seems to have never worked before. [PR #5629](https://github.com/apollographql/apollo-server/pull/5629) ## v3.1.2