Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More non spring examples + proper docs + bunch of questions #17

Closed
RIP21 opened this issue Jul 17, 2019 · 2 comments
Closed

More non spring examples + proper docs + bunch of questions #17

RIP21 opened this issue Jul 17, 2019 · 2 comments

Comments

@RIP21
Copy link

RIP21 commented Jul 17, 2019

Hi there.
I understand how Spring Boot and Spring itself is beneficial (especially for microservices), but I really want to see pure implementation with 2-3 different federated services written in graphql-java and apollo-server that sticks it all as a whole thing using a gateway.

Another question is, will Apollo Engine work with those graphql-java federated services, or they will be a bunch of black boxes until proper apollo-engine instrumentation is implemented? (I mean resolvers tracing and all advanced, not static schema related stuff)

If they indeed will, is Apollo has any plans to implement some sort of library that will help with instrumentation of graphql-java based GraphQL Servers? It's kind of roadblock for us to start to consider it at Revolut.

(we have all backend in Java/Kotlin and we're moving heavily towards microservices, Node.js is not an option with that amount of JVM devs, and I'm as an evangelist of GQL in the company, want to make sure everything is there for GraphQL in JVM world, to start promoting it heavily or even build a prototype for them, also, Spring is forbidden in our company, that's why I'm looking for Spring agnostic implementation)

@RIP21 RIP21 changed the title More non spring examples + proper docs More non spring examples + proper docs + bunch of questions Jul 17, 2019
@glasser
Copy link
Member

glasser commented Sep 27, 2019

See #25 for federated tracing support.

@zionts
Copy link

zionts commented Jan 14, 2020

I'm going to close this out in favor of #9 , which calls for a clearer roadmap and some more information about the project, release notes, etc.

We know that there is a big gap in the documentation for this library as well as expectations for the community, and I'm sorry it's taken this long to get back to you with clear communication. This library was originally started as a way to support our own Kotlin services in the Apollo back-end, and we haven't been as proactive as we would have liked as an open source project. We would welcome more partnership in open source maintenance if you're interested!

To respond to your specific comments about this library, though: this library is recommended for production GraphQL services underneath an Apollo gateway and is currently used in production by both ourselves at Apollo as well as other Apollo gateway users. Additionally, we don't use Spring internally with this implementation and we only illustrated it in the example because of its popularity. Perhaps an implementation with ktor (what we use internally) would be a useful example to share?

@zionts zionts closed this as completed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants