Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query-planner-js): Strip application of directives from the API schema, not just their declarations #683

Open
trevor-scheer opened this issue Apr 22, 2021 · 1 comment
Open

fix(query-planner-js): Strip application of directives from the API schema, not just their declarations #683

trevor-scheer opened this issue Apr 22, 2021 · 1 comment

Comments

@trevor-scheer
Copy link
Member

Entire context of this issue is captured by a comment left on a previous PR: #622 (comment)

Following the recommended suggestion in that comment broke a bunch of tests (presumably because there's a dependence on these AST nodes in various places) so this may not be trivial or even possible.
@trevor-scheer trevor-scheer mentioned this issue Apr 22, 2021
Merged
17 tasks
@pcmanus
Copy link
Contributor

pcmanus commented Nov 15, 2021

I'm 99.9% sure this isn't a problem anymore in the federation 2 code. Do we want to keep this open for the version-0.x branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcmanus @trevor-scheer