Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved generic typings for makeExecutableSchema #662

Merged
merged 4 commits into from
Mar 13, 2018
Merged

Improved generic typings for makeExecutableSchema #662

merged 4 commits into from
Mar 13, 2018

Conversation

icopp
Copy link
Contributor

@icopp icopp commented Mar 5, 2018

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
    • This is a small change
  • Make sure all of the significant new logic is covered by tests
    • No new logic
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

This PR adds generic typings to several interfaces related to resolvers, adds an optional TContext type parameter to makeExecutableSchema, and exports the interfaces file (so that the generic-ified types can be used to give a type signature to objects manually, especially for uses of TSource).

@apollo-cla
Copy link

@icopp: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants