From 00fa9be06bbe80515cbc7f775362db23b27f996e Mon Sep 17 00:00:00 2001 From: Ben Newman Date: Thu, 13 Dec 2018 17:55:06 -0500 Subject: [PATCH] Move walkTree export to react-apollo/walkTree, to avoid bundling it. --- Changelog.md | 8 ++++++++ rollup.config.js | 3 +++ src/browser.ts | 2 -- test/client/getDataFromTree.test.tsx | 2 +- 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/Changelog.md b/Changelog.md index f52901da31..0f1fdd4320 100644 --- a/Changelog.md +++ b/Changelog.md @@ -6,6 +6,14 @@ ### Improvements +- The `walkTree` function has been deprecated, since there's no way to + make its behavior consistent with the latest versions of React. To save + bundle size, `walkTree` is no longer exported from `react-apollo`, + though you can still access it as follows: + ```js + import { walkTree } from "react-apollo/walkTree" + ``` + ## 2.3.3 ### Bug Fixes diff --git a/rollup.config.js b/rollup.config.js index e72c5ff20b..677f5c8248 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -44,6 +44,9 @@ export default [ // for test-links umd("lib/test-links.js", "lib/test-links.js"), + // Enable `import { walkTree } from "react-apollo/walkTree"` + umd("lib/walkTree.js", + "lib/walkTree.js"), // for filesize { input: 'lib/react-apollo.browser.umd.js', diff --git a/src/browser.ts b/src/browser.ts index 8ca7bb6632..3eb8f1c69d 100644 --- a/src/browser.ts +++ b/src/browser.ts @@ -26,6 +26,4 @@ export * from './withApollo'; export * from './types'; -export * from './walkTree'; - export { compose } from './utils/flowRight'; diff --git a/test/client/getDataFromTree.test.tsx b/test/client/getDataFromTree.test.tsx index fe4a6eaf3e..ce7a03aeb2 100644 --- a/test/client/getDataFromTree.test.tsx +++ b/test/client/getDataFromTree.test.tsx @@ -6,12 +6,12 @@ import { graphql, Query, ApolloProvider, - walkTree, getDataFromTree, getMarkupFromTree, DataValue, ChildProps, } from '../../src'; +import { walkTree } from "../../src/walkTree"; import gql from 'graphql-tag'; const times = require('lodash.times'); import { InMemoryCache as Cache } from 'apollo-cache-inmemory';