Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Check for client comes too late #183

Closed
tmeasday opened this issue Sep 1, 2016 · 2 comments · Fixed by #189
Closed

Check for client comes too late #183

tmeasday opened this issue Sep 1, 2016 · 2 comments · Fixed by #189
Assignees

Comments

@tmeasday
Copy link
Contributor

tmeasday commented Sep 1, 2016

This line https://github.com/apollostack/react-apollo/blob/master/src/graphql.tsx#L262 is kind of redundant right now because it will have already errored on the line before.

@jbaxleyiii should I just fix this on devel?

While we are on the subject is it odd that we preference props.client to context.client? It's a bit of a gotcha that people can't use a prop to their component called client, and I'm not sure it's documented anywhere.

@jbaxleyiii
Copy link
Contributor

@tmeasday thats a great point on both regards! Let's remove the prop usage and fix the warning!

@jbaxleyiii
Copy link
Contributor

Fixed in next release!

@zol zol removed the in progress label Sep 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants