Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

mapStateToProps params #20

Closed
johnthepink opened this issue Apr 19, 2016 · 7 comments
Closed

mapStateToProps params #20

johnthepink opened this issue Apr 19, 2016 · 7 comments
Labels

Comments

@johnthepink
Copy link
Contributor

It looks like mapStateToProps currently gets called with just the redux state. The docs show that it gets called with an object containing ownProps and state. Is it intended to contain ownProps as well? Or should we update the docs? cc @jbaxleyiii

@jbaxleyiii
Copy link
Contributor

@johnthepink it should have ownProps. I thought I had a test in place for that?

@stubailo
Copy link
Contributor

I had a few issues with various arguments as well. I don't think our tests totally cover the different lifecycle events with changes coming from props, redux, etc.

@jbaxleyiii
Copy link
Contributor

jbaxleyiii commented Apr 19, 2016

@stubailo the tests are pretty minimal right now. @johnthepink would you be up to taking that for me today and tomorrow? Trying to be better about actually being on vacation ;)

@stubailo
Copy link
Contributor

I managed to build an example app on top of it, so I'm happy! No rush on making these improvements, I think - vacation away!

@jbaxleyiii
Copy link
Contributor

@stubailo @johnthepink is triumphantly moving our stavj to Apollo now so he may need some changes.

I'm really happy it's all decent ly coming together though!

@johnthepink
Copy link
Contributor Author

Yep! I'll jump in on fixing some stuff here soon. Found a couple other things.

@jbaxleyiii
Copy link
Contributor

Fixed with #51

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants