Don't fire any query observables if the query result didn't change #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn't call this "diffing", we should probably come up with a new name. At the end of the day, this can be summarized as "don't fire any query observables if the query result didn't change." |
Poincare
changed the title
| // Given a query id and a new result, this checks if the old result is | ||
| // the same as the last result for that particular query id. | ||
| private isDifferentResult(queryId: string, result: ApolloQueryResult): boolean { | ||
| return !isEqual(this.queryResults[queryId], result); |
There was a problem hiding this comment.
I don't think this will work in all cases right? Don't you need to use deepEqual?
This was referenced Jul 18, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that observables are only fired when the data received changes. This means that observers will only be fired if there's an updated result in the store. We do a deep diff before doing this. Solves #400.
I ran a comparison using the Chrome CPU profiler with and without this particular changeset on the Galaxy UI.
Before:
After:
There is a single large element on this page that isn't changing in this particular query. As you can see clearly in the "before", this element is rendered for no reason and this rendering is eliminated in the "after". Secondly, there is also consistently reduced time to render the list of items that are changing since some of them don't actually change (~80ms to ~40ms). This isn't a particularly complex page so the performance improvements aren't incredible but it is easy to imagine cases where polling queries would be needlessly causes re-renders within React.
TODO: